feat(documents): invoice due dates — terms default + override, honest overdue chase (Phase 1, D18)
- document.due_date additive column; billing.payment_terms_days seeded (15) - issueDocument stamps doc_date+terms on INVOICE when absent — covers manual issue, convert-and-send and recurring generation in one place - drafts accept dueDate (INVOICE only, validated); composer date field auto-filled from GET /settings/billing; invoice PDF prints Due Date - overdue scan + reminder anchor on COALESCE(due_date, doc_date); email says 'was due on X and is now N day(s) overdue' when a due date exists - legacy fixtures pinned to due_date=NULL (sanctioned: they test the doc_date anchor); 9 new tests; suite 309/309 across 60 files Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>feat/client-detail-redesign
Thomas Joise
5 days ago
parent
aa05060181
commit
bc140fc54c
@ -0,0 +1,122 @@
|
||||
// apps/hq/test/due-dates.test.ts — go-live cluster WS-A: invoice due dates (D18)
|
||||
import { describe, it, expect } from 'vitest'
|
||||
import { openDb } from '../src/db'
|
||||
import { seedIfEmpty } from '../src/seed'
|
||||
import { createClient } from '../src/repos-clients'
|
||||
import { createModule, setPrice } from '../src/repos-modules'
|
||||
import { convertDocument, createDraft, getDocument, issueDocument } from '../src/repos-documents'
|
||||
import { getReminder, listReminders, setSetting, upsertReminder } from '../src/repos-reminders'
|
||||
import { reminderContext } from '../src/send-reminder'
|
||||
import { reminderEmail } from '../src/reminder-templates'
|
||||
import { runDailyScan, type ScanDeps } from '../src/scheduler'
|
||||
|
||||
const deps: ScanDeps = {
|
||||
gmail: { f: (async () => new Response('{}')) as typeof fetch, clientId: '', clientSecret: '', keyHex: '' },
|
||||
renderPdf: async () => Buffer.from('%PDF-'), company: () => ({ 'company.name': 'Tecnostac' }),
|
||||
now: () => '2026-07-17T00:00:00Z',
|
||||
}
|
||||
|
||||
function world() {
|
||||
const db = openDb(':memory:'); seedIfEmpty(db) // seeds billing.payment_terms_days=15
|
||||
const c = createClient(db, 'u1', { name: 'Acme', stateCode: '32', contacts: [{ name: 'R', email: 'r@acme.in' }] })
|
||||
const m = createModule(db, 'u1', { code: 'POS', name: 'POS' })
|
||||
setPrice(db, 'u1', { moduleId: m.id, kind: 'yearly', pricePaise: 10_000_00, effectiveFrom: '2026-01-01' })
|
||||
const invoiceDraft = () => createDraft(db, 'u1', {
|
||||
docType: 'INVOICE', clientId: c.id, lines: [{ moduleId: m.id, qty: 1, kind: 'yearly' }],
|
||||
})
|
||||
return { db, c, m, invoiceDraft }
|
||||
}
|
||||
|
||||
describe('due dates (D18)', () => {
|
||||
it('issue stamps doc_date + terms on an invoice without one (manual issue path)', () => {
|
||||
const { db, invoiceDraft } = world()
|
||||
const draft = invoiceDraft()
|
||||
expect(draft.dueDate).toBeNull()
|
||||
db.prepare(`UPDATE document SET doc_date='2026-07-01' WHERE id=?`).run(draft.id)
|
||||
const inv = issueDocument(db, 'u1', draft.id)
|
||||
expect(inv.dueDate).toBe('2026-07-16') // 2026-07-01 + 15
|
||||
})
|
||||
|
||||
it('a caller-provided due date survives issue untouched', () => {
|
||||
const { db, c, m } = world()
|
||||
const draft = createDraft(db, 'u1', {
|
||||
docType: 'INVOICE', clientId: c.id, dueDate: '2026-09-30',
|
||||
lines: [{ moduleId: m.id, qty: 1, kind: 'yearly' }],
|
||||
})
|
||||
expect(draft.dueDate).toBe('2026-09-30')
|
||||
expect(issueDocument(db, 'u1', draft.id).dueDate).toBe('2026-09-30')
|
||||
})
|
||||
|
||||
it('the terms setting is honoured when changed (dated behavior lives in the stamp)', () => {
|
||||
const { db, invoiceDraft } = world()
|
||||
setSetting(db, 'u1', 'billing.payment_terms_days', '30')
|
||||
const draft = invoiceDraft()
|
||||
db.prepare(`UPDATE document SET doc_date='2026-07-01' WHERE id=?`).run(draft.id)
|
||||
expect(issueDocument(db, 'u1', draft.id).dueDate).toBe('2026-07-31')
|
||||
})
|
||||
|
||||
it('quotes and proformas never get a due date — at draft or at issue', () => {
|
||||
const { db, c, m } = world()
|
||||
expect(() => createDraft(db, 'u1', {
|
||||
docType: 'QUOTATION', clientId: c.id, dueDate: '2026-08-01',
|
||||
lines: [{ moduleId: m.id, qty: 1, kind: 'yearly' }],
|
||||
})).toThrow(/INVOICE/)
|
||||
const pi = createDraft(db, 'u1', {
|
||||
docType: 'PROFORMA', clientId: c.id, lines: [{ moduleId: m.id, qty: 1, kind: 'yearly' }],
|
||||
})
|
||||
expect(issueDocument(db, 'u1', pi.id).dueDate).toBeNull()
|
||||
})
|
||||
|
||||
it('proforma → invoice conversion gets stamped at issue (convert-and-send path)', () => {
|
||||
const { db, c, m } = world()
|
||||
const pi = issueDocument(db, 'u1', createDraft(db, 'u1', {
|
||||
docType: 'PROFORMA', clientId: c.id, lines: [{ moduleId: m.id, qty: 1, kind: 'yearly' }],
|
||||
}).id)
|
||||
const invDraft = convertDocument(db, 'u1', pi.id, 'INVOICE')
|
||||
const inv = issueDocument(db, 'u1', invDraft.id)
|
||||
expect(inv.dueDate).not.toBeNull() // stamped from terms on the invoice's own doc_date
|
||||
})
|
||||
|
||||
it('bad dueDate format is rejected at draft', () => {
|
||||
const { db, c, m } = world()
|
||||
expect(() => createDraft(db, 'u1', {
|
||||
docType: 'INVOICE', clientId: c.id, dueDate: '17-07-2026',
|
||||
lines: [{ moduleId: m.id, qty: 1, kind: 'yearly' }],
|
||||
})).toThrow(/YYYY-MM-DD/)
|
||||
})
|
||||
|
||||
it('overdue scan anchors on the due date: not yet due ⇒ silent, past due ⇒ milestone from due_date', async () => {
|
||||
const { db, invoiceDraft } = world()
|
||||
// Old issue date but due date in the future → NOT overdue.
|
||||
const a = issueDocument(db, 'u1', invoiceDraft().id)
|
||||
db.prepare(`UPDATE document SET doc_date='2026-05-01', due_date='2026-08-01' WHERE id=?`).run(a.id)
|
||||
// Due 16 days ago → d15 milestone (7/15/30 ladder), counted from due_date not doc_date.
|
||||
const b = issueDocument(db, 'u1', invoiceDraft().id)
|
||||
db.prepare(`UPDATE document SET doc_date='2026-05-01', due_date='2026-07-01' WHERE id=?`).run(b.id)
|
||||
await runDailyScan(db, deps, '2026-07-17')
|
||||
const rows = listReminders(db, {}).filter((r) => r.ruleKind === 'invoice_overdue')
|
||||
expect(rows).toHaveLength(1)
|
||||
expect(rows[0]).toMatchObject({ subjectId: b.id, duePeriod: 'd15' })
|
||||
})
|
||||
|
||||
it('the reminder email says "was due on X and is now N day(s) overdue"', () => {
|
||||
const { db, c, invoiceDraft } = world()
|
||||
const inv = issueDocument(db, 'u1', invoiceDraft().id)
|
||||
db.prepare(`UPDATE document SET due_date='2026-07-02' WHERE id=?`).run(inv.id)
|
||||
const { id } = upsertReminder(db, { ruleKind: 'invoice_overdue', subjectId: inv.id, duePeriod: 'd15', clientId: c.id, docId: inv.id, now: '2026-07-17T00:00:00Z' })
|
||||
const { ctx } = reminderContext(db, getReminder(db, id)!, 'Tecnostac', '2026-07-17')
|
||||
expect(ctx.dueDate).toBe('2026-07-02')
|
||||
expect(ctx.daysOverdue).toBe(15)
|
||||
expect(reminderEmail('invoice_overdue', ctx).bodyText).toMatch(/was due on 2026-07-02 and is now 15 day\(s\) overdue/)
|
||||
})
|
||||
|
||||
it('legacy invoices without a due date keep the past-due-since-issue wording and doc_date anchor', () => {
|
||||
const { db, c, invoiceDraft } = world()
|
||||
const inv = issueDocument(db, 'u1', invoiceDraft().id)
|
||||
db.prepare(`UPDATE document SET doc_date='2026-07-07', due_date=NULL WHERE id=?`).run(inv.id)
|
||||
const { id } = upsertReminder(db, { ruleKind: 'invoice_overdue', subjectId: inv.id, duePeriod: 'd7', clientId: c.id, docId: inv.id, now: '2026-07-17T00:00:00Z' })
|
||||
const { ctx } = reminderContext(db, getReminder(db, id)!, 'Tecnostac', '2026-07-17')
|
||||
expect(ctx.dueDate).toBeUndefined()
|
||||
expect(reminderEmail('invoice_overdue', ctx).bodyText).toMatch(/is outstanding and is now 10 day\(s\) past due/)
|
||||
})
|
||||
})
|
||||
Loading…
Reference in New Issue