You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
400abc224f
Review findings on the quote-to-close slice, each verified against the code: - convertDocument: ANY conversion now flips the source to 'invoiced' (previously only ->INVOICE), so a QT->PI quote leaves the daily scan's 'sent' set and the pipeline's Quoted/Waiting — the chase never resumes after convert (spec 7 stop conditions). Scan additionally excludes quotes with a live forward child (covers rows converted before this fix) and quotes of lost clients. - convertDocument rule-4 guard (spec 8 F4): a live non-cancelled forward child blocks re-convert — one sale, one legal document; cancelling the child re-opens the path. Rule-2 fix (spec 8 F3): ->INVOICE recomputes the carried lines through computeBill on the invoice's own doc_date (mirrors createCreditNote); QT->PI stays copy-only (both non-legal). - cancelDocument dismisses a cancelled quotation's open follow-up nudges in the same transaction, per-row audited — dead paper is not chased. - GET /reminders?status= no longer bypasses the owner scope and pagination: the status param narrows the same scoped listQueue view. Web badge (Layout) now uses the honest scoped total instead of an unscoped flat list length. - listQueue/queueCounts staff scope keeps doc-less reminders (renewal_due, amc_expiring, follow_up, email_bounced) visible — they have no derived owner and are shared work; previously they vanished for every staff viewer. - sendReminder resolves the recipient BEFORE minting a public share (a send that can never succeed leaves no live artifact) and refuses quote_followup sends loudly when share.base_url is unset instead of emailing a dead relative link. The scheduler auto-drain parks a hard-failing send as 'failed' with its reason instead of crashing the scan. - reminderContext takes an injectable today (threaded from deps.now in the send path) so dated schedule text resolves deterministically. - Pipeline: quote-less lost clients (client.status=lost) now appear under filter=lost (spec 9); Dashboard queue table marks first-page truncation honestly (rule 8). Typecheck clean; 270 tests green (255 before, +15 covering each fix). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
5 days ago | |
|---|---|---|
| .. | ||
| scripts | 1 week ago | |
| src | 5 days ago | |
| test | 5 days ago | |
| .env.example | 1 week ago | |
| build-server.mjs | 2 weeks ago | |
| package.json | 2 weeks ago | |
| schema.sql | 2 weeks ago | |
| tsconfig.json | 2 weeks ago | |