From 0be928fbf817c2f1a2f925b058894bb2249b2d59 Mon Sep 17 00:00:00 2001
From: Thomas Joise <thomas.joise@tecnostac.com>
Date: Fri, 17 Jul 2026 02:16:17 +0530
Subject: [PATCH] fix(hq-web): Employees page no longer shows a permanent
 Loading state on fetch failure
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

employees stays undefined when getEmployees rejects, so the page rendered
the error Notice AND an eternal "Loading…" EmptyState below it. Branch on
list.error first.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 apps/hq-web/src/pages/Employees.tsx | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/apps/hq-web/src/pages/Employees.tsx b/apps/hq-web/src/pages/Employees.tsx
index 6d129d9..c24f593 100644
--- a/apps/hq-web/src/pages/Employees.tsx
+++ b/apps/hq-web/src/pages/Employees.tsx
@@ -61,7 +61,10 @@ export function Employees() {
       )}
       {error !== undefined && <Notice tone="err">{error}</Notice>}
       {list.error !== undefined && <Notice tone="err">{list.error}</Notice>}
-      {employees === undefined ? <EmptyState>Loading…</EmptyState>
+      {/* Branch on the fetch error first — `employees` stays undefined on failure,
+          so falling through would show "Loading…" forever under the error notice. */}
+      {list.error !== undefined ? null
+        : employees === undefined ? <EmptyState>Loading…</EmptyState>
         : employees.length === 0 ? <EmptyState>No employees yet.</EmptyState> : (
         <>
           <DataTable